It does seem to be related to the automatic item pickup thingy people are using. I booted the ones using it/asked them to turn it off. Lag seems to be gone according to the players.

Why you say people when you know exactly who did it and make it look like all of us was causing it?
i even dmed you in discord about exactly what caused the lag and your reply was "idc tell james" no?

Turns out 25 players use 20% server CPU.
1 player using the macro increases it to 50%. So, 3 players causes 100%, and then everyone gets lag.
The main problem is it sends a ton of packets for objects that aren't even there.

I am going to change the pick-up packet to use object ID instead of location next week. That will solve the problem permanently. This is great. I thought the problem would be more difficult to solve.

Thanks for finding the problem Mr Spy, and thanks for revealing the problem bullethead123. I want to make the server resilient to all kinds of packets, and clearly, object pick-up is an area that is very inefficient.

It turns out everyone gets punished because 3 peoples mistakes

Nvm i know who it is. Keep an eye on anthonyrules, i believe it should not be an issue now but please do let me know if it is still causing problems. When other users restart they'll be moved onto same version anthonyrules is on.

Judging by CPU usage, we have one person online using your macro, and the server bandwidth over 30 seconds is
RX to server: 9547362 bytes (318KB/s)
TX from server: 873424 bytes (29KB/s)
As it's typically 1KB/s both ways per player, I think it's safe to say the macro is DOSing the server. Enough packets per macroer for 200 players. This is doubly funny actually, because the server is only on a 10 megabit (1.25MB/s) line, so not only are you maxing the CPU but also probably running me out of bandwidth.

Thinking of it now, the best way to solve this is a general bandwidth limit per player. No wonder it was lagging.

for (int dx = -collectionRadius; dx <= collectionRadius; ++dx) {
        for (int dy = -collectionRadius; dy <= collectionRadius; ++dy) {
            int targetX = currentX + dx;
            int targetY = currentYDecoded + dy;

            SendCollectionPacket(targetX, targetY);
        }
    }

IT was spamming the above function with no delay. SO probably like hundreds a second.

I've corrected it now, I think that should solve the issue. I also reduced the radius from 3 tiles to 1.

Turns out 25 players use 20% server CPU.
1 player using the macro increases it to 50%. So, 3 players causes 100%, and then everyone gets lag.
The main problem is it sends a ton of packets for objects that aren't even there.

I am going to change the pick-up packet to use object ID instead of location next week. That will solve the problem permanently. This is great. I thought the problem would be more difficult to solve.

Thanks for finding the problem Mr Spy, and thanks for revealing the problem bullethead123. I want to make the server resilient to all kinds of packets, and clearly, object pick-up is an area that is very inefficient.

I love your mindset as a developer. Rather than crying about the problem (or people doing it) you look to implement a solution.

I am going to change the pick-up packet to use object ID instead of location next week. That will solve the problem permanently. This is great. I thought the problem would be more difficult to solve.

Thanks for finding the problem Mr Spy, and thanks for revealing the problem bullethead123. I want to make the server resilient to all kinds of packets, and clearly, object pick-up is an area that is very inefficient.

Yes that is mine. I apologize it was not my intention to cause issues for players. I'm disabling that feature for anyone using at this time.

Thanks

pennywise wrote:

They're injecting an old.dll hack called Maldon.  It hooks on faldon and spams auto attack and auto pick up commands...looks like api calls, not packet editing.  The commands should work seperate from one another, so I dunno why the auto pickup was on.  It also only works on old client.

Its not Maldon what theyre using but ''Faldron'' its been advertised on the game and discord. But its the same thing except the auto loot is probably always on.

Well, i think there are only 2 ppl using that, and current lag is older than that program. Plus that is not the same as Maldon (almost a complete trash). James is right, people who use it crashes multiple times when injecting its dll, i've seen that with my eyes too, but i dont think lag is related to that.

They're injecting an old.dll hack called Maldon.  It hooks on faldon and spams auto attack and auto pick up commands...looks like api calls, not packet editing.  The commands should work seperate from one another, so I dunno why the auto pickup was on.  It also only works on old client.

Its not Maldon what theyre using but ''Faldron'' its been advertised on the game and discord. But its the same thing except the auto loot is probably always on.

Not a given that no one is using that type of program. I get crash reports from a guy using "FaldonInject.dll" all the time.
*That said*, the server needs to be tolerant of whatever comes its way.

2024/08/23 did also add script caching. It's possible that doesn't work as well as it should. I'm going to try and figure out a way to run a profiler on the server code this coming week.